Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade Elixir and Erlang to latest versions, add Elixir 1.16 to CI #1055

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

ruslandoga
Copy link
Contributor

No description provided.

elixir 1.15
erlang 26.1.2
elixir 1.16.2-otp-26
erlang 26.2.5
Copy link
Contributor Author

@ruslandoga ruslandoga May 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if there is a way to make it less restrictive? So that any otp-26 and Elixir 1.16 would be fine.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The point of .tools-versions is to get everyone who's working on this directly using the same version - it's deliberately highly prescriptive so that, for example, we're not all using different versions to run mix format :)

@bernardd
Copy link
Contributor

bernardd commented Jun 4, 2024

Thanks @ruslandoga - this is great. Could you move the lint tag in the workflow onto the new pair so that the CI formatting version check matches the default .tool-versions one? Then we'll get this merged. Sorry for taking a while to get to it.

@bernardd
Copy link
Contributor

bernardd commented Jun 4, 2024

Oh, nevermind, turns out I can edit PRs myself :) Thanks :)

@bernardd bernardd merged commit 66c5c36 into ex-aws:main Jun 4, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants