sso_session support in .aws/config #1048
Merged
+51
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siestakimberly
approved these changes
Apr 10, 2024
lmarlow
approved these changes
Apr 12, 2024
|
Love this! Very nice! |
|
Hi, This is really helpful. Are there plans to merge this soon? |
|
Thanks heaps @rjenkins2. Apologies for taking so long to get to this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sso_session in ~/.aws/config work properly. See issue #951
It simply merges in the config entries from the specified sso-session section. It also changes the cache_key used from sso_start_url to the sso_session name when sso_session is specified.