Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(evm): duplicate event emitting #2559

Merged
merged 4 commits into from
May 17, 2024
Merged

fix(evm): duplicate event emitting #2559

merged 4 commits into from
May 17, 2024

Conversation

Vvaradinov
Copy link
Contributor

Description

This PR fixes the duplicate event emitting of cached events which causes Delegate transactions (possibly others as well) through precompiles to double the events emitted.

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted the correct branch (see PR Targeting)

Reviewers Checklist

All items are required.
Please add a note if the item is not applicable
and please add your handle next to the items reviewed
if you only reviewed selected items.

I have...

  • added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • confirmed all author checklist items have been addressed
  • confirmed that this PR does not change production code
  • reviewed content
  • tested instructions (if applicable)
  • confirmed all CI checks have passed

@Vvaradinov Vvaradinov requested a review from a team as a code owner May 15, 2024 13:37
@Vvaradinov Vvaradinov requested review from hanchon and ramacarlucho and removed request for a team May 15, 2024 13:37
0xstepit
0xstepit approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@0xstepit 0xstepit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job Vlad!

@0xstepit 0xstepit merged commit 211b644 into main May 17, 2024
44 checks passed
@0xstepit 0xstepit deleted the Vvaradinov/duplicate-event-emitting branch May 17, 2024 12:59
facs95 pushed a commit that referenced this pull request May 29, 2024
@Vvaradinov @facs95
fix(evm): duplicate event emitting (#2559)
958750b 
* fix: duplicate event emitting

* CHANGELOG

* CHANGELOG
GAtom22 pushed a commit that referenced this pull request May 29, 2024
@facs95 @Vvaradinov
fix(evm): duplicate event emitting (#2559) (#2585)
ef1a6e3 
* fix: duplicate event emitting

* CHANGELOG

* CHANGELOG

Co-authored-by: Vladislav Varadinov <vladislav.varadinov@gmail.com>
@MalteHerrmann MalteHerrmann linked an issue May 30, 2024 that may be closed by this pull request
EVM Events Generated twice. #2312
Closed
@MalteHerrmann MalteHerrmann mentioned this pull request May 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramacarlucho ramacarlucho ramacarlucho approved these changes

@0xstepit 0xstepit 0xstepit approved these changes

@hanchon hanchon Awaiting requested review from hanchon hanchon is a code owner automatically assigned from evmos/core-engineering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EVM Events Generated twice.
3 participants
@Vvaradinov @ramacarlucho @0xstepit