fix(rpc/types): catch invalid values in CheckTxFee #2415
Conversation
This change catches invalid values in CheckTxFee and returns an error for: * nil gasPrice * negative gasPrice which improves the reliability of the system. Fixes evmos#2413 Fixes evmos#2414
odeke-em
requested review from
facs95 and
0xstepit
and removed request for
a team
|
|
|
I believe that this change is warranted to fix a violation of the Ethereum specification that warrants that every transaction must have a non-zero gas price per https://ethereum.github.io/yellowpaper/paper.pdf |
Hey @odeke-em, Thank you for your contribution to our codebase! Your effort is much appreciated. Regarding your pull request, I recommend taking a look at the ante handler, as it contains most of the checks related to gas. Additionally, I want to inform you that we're currently discussing internal plans to refactor and enhance RPC performance. As a result, I'll be closing this PR to avoid further investment of your time in addressing CI issues. Once again, thank you for your contribution. 🙏 |
This change catches invalid values in CheckTxFee
and returns an error for:
which improves the reliability of the system.
Fixes #2413
Fixes #2414