Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jsonrpc): add support for allow-insecure-unlock #2374

Closed
wants to merge 2 commits into from
Closed

feat(jsonrpc): add support for allow-insecure-unlock #2374

wants to merge 2 commits into from

Conversation

timwhite2
Copy link
Contributor

@timwhite2 timwhite2 commented Feb 23, 2024

Description

Closes: #1657.
This pull request is based on #1657.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted the correct branch (see PR Targeting)

Reviewers Checklist

All items are required.
Please add a note if the item is not applicable
and please add your handle next to the items reviewed
if you only reviewed selected items.

I have...

  • added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • confirmed all author checklist items have been addressed
  • confirmed that this PR does not change production code
  • reviewed content
  • tested instructions (if applicable)
  • confirmed all CI checks have passed

Allow insecure account unlocking when account-related RPCs are exposed by http
@timwhite2 timwhite2 requested a review from a team as a code owner February 23, 2024 08:37
@timwhite2 timwhite2 requested review from facs95 and MalteHerrmann and removed request for a team February 23, 2024 08:37
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


tim seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@timwhite2 timwhite2 closed this Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem: keyring-backend test leading to accounts to be drained when 8545 exposed public
3 participants