Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp(distribution): replace bech32 address with evm hex address for distribution precompile contract #2241

Draft
wants to merge 28 commits into
base: main
Choose a base branch
from

Conversation

luchenqun
Copy link
Contributor

Description

Please review #2200 first, because this is modified based on this PR

More details see before #2122

@luchenqun luchenqun requested a review from a team as a code owner January 5, 2024 16:51
@luchenqun luchenqun requested review from facs95 and removed request for a team January 5, 2024 16:51
@luchenqun luchenqun changed the title imp(distribution): replace bech32 address with evm hex address for staking precompile contract imp(distribution): replace bech32 address with evm hex address for distribution precompile contract Jan 5, 2024
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: Patch coverage is 77.55102% with 33 lines in your changes are missing coverage. Please review.

Project coverage is 70.42%. Comparing base (aa0b9d5) to head (3e4e459).
Report is 152 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2241      +/-   ##
==========================================
- Coverage   70.53%   70.42%   -0.11%     
==========================================
  Files         291      291              
  Lines       22617    22657      +40     
==========================================
+ Hits        15953    15957       +4     
- Misses       5798     5822      +24     
- Partials      866      878      +12     
Files Coverage Δ
precompiles/distribution/tx.go 67.07% <0.00%> (ø)
precompiles/distribution/events.go 75.22% <62.50%> (-2.55%) ⬇️
precompiles/distribution/query.go 82.85% <40.00%> (-8.24%) ⬇️
precompiles/distribution/types.go 89.14% <87.75%> (-3.65%) ⬇️
precompiles/staking/types.go 87.28% <76.19%> (-0.05%) ⬇️

... and 3 files with indirect coverage changes

@luchenqun
Copy link
Contributor Author

When executing the make lint-fix command, the following errors are found, but in fact they are only partially duplicated. How do you usually fix these problems?

Error: 64-89 lines are duplicate of `precompiles/distribution/types.go:92-117` (dupl)
  Error: 92-117 lines are duplicate of `precompiles/distribution/types.go:64-89` (dupl)
  Error: 57-77 lines are duplicate of `precompiles/distribution/events_test.go:129-149` (dupl)
  Error: 129-149 lines are duplicate of `precompiles/distribution/events_test.go:57-77` (dupl)
  Error: 504-513 lines are duplicate of `precompiles/distribution/integration_test.go:1[36](https://github.com/evmos/evmos/actions/runs/7424496428/job/20204246603?pr=2241#step:5:38)7-1376` (dupl)
  Error: 1367-1[37](https://github.com/evmos/evmos/actions/runs/7424496428/job/20204246603?pr=2241#step:5:39)6 lines are duplicate of `precompiles/distribution/integration_test.go:504-513` (dupl)

@hanchon
Copy link
Contributor

hanchon commented Jan 18, 2024

The PR looks good, but we need the same typescript library mentioned in #2200 in order to give solutions to the tools already created for our users.

We should be able to finish the review and merge it as soon as the typescript lib is available.

@hanchon hanchon marked this pull request as draft January 18, 2024 19:07
Copy link

github-actions bot commented Mar 4, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days-before-close if no further activity occurs.

@VictorTrustyDev
Copy link
Contributor

Not Stale

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days-before-close if no further activity occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants