Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GPS plugin to allow connecting to GPSD #1123

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

llamasoft
Copy link

Fixes #1122

Bettercap supports connecting to a GPSD server with hostname:port since v2.29.
This allows users to use GPSD/chrony to set the system clock while still being able to use the GPS plugin.

Motivation and Context

  • I have raised an issue to propose this change (required)

How Has This Been Tested?

I had to make this change on my personal pwnagotchi in order for it to use GPSD.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s

Bettercap supports connecting to a GPSD server with hostname:port
since v2.29.  This allows users to use GPSD/chrony to set the
system clock while still being able to use the GPS plugin.

Signed-off-by: llamasoft <llamasoft@rm-rf.email>
@makerph
Copy link

makerph commented Oct 24, 2022

this update supports GPS coming from Mobile phone using mobile apps?

@llamasoft
Copy link
Author

this update supports GPS coming from Mobile phone using mobile apps?

No. This update only affects Pwnagotchis using a hardware GPS module like this one.

swanserquack added a commit to swanserquack/pwnagotchi that referenced this pull request May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] GPS plugin considers hostname:port device invalid despite bettercap supporting it
2 participants