Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIActivityIndicator #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

UIActivityIndicator #17

wants to merge 1 commit into from

Conversation

xamelon
Copy link

@xamelon xamelon commented Oct 4, 2017

Added UIActivityIndicator when image is downloading

@evgenyneu
Copy link
Owner

Hi @xamelon, good idea. Here are things that need to be done before it is merged:

  • Create activity indicator when image starts downloading, and not on init, since download does not necessarily needs to start after the image view is created.

  • Handle case when one moa image view displays multiple images in succession: one after another. In each case, indicator should be created on download and removed when it finishes/fails.

  • Only create activity indicator object when it is needed. Don't create it by default, since most current users don't need it, or don't expect it to be there. This can be done by adding a setting moa.showActivityIndicator = true, which is false by default.

  • Position activity indicator using auto layout constraints instead of frame coordinates. This will ensure the indicator remains in place when image view changes size (on phone orientation change, for example).

  • Add unit test.

  • Add documentation to readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants