Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automatic translations with google #174

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

haringsrob
Copy link

Hi,

This is a proposal pr for adding google translate as an automatic translation service.

While the pr needs still a lot of work I wanted to share this draft so we can discuss if it is something good or not for this project.

I have never worked with typescript, I did my best to follow conventions but sorry if I missed out on things.

There are quite some todo's inline that further describe the idea, potential issues and improvements that can be done.

Thank you for this awesome project!

Hi,

This is a proposal pr for adding google translate as an automatic translation service.

While the pr needs still a lot of work I wanted to share this draft so we can discuss if it is something good or not for this project.

I have never worked with typescript, I did my best to follow conventions but sorry if I missed out on things.

There are quite some todo's inline that further describe the idea, potential issues and improvements that can be done.

Thank you for this awesome project!
@CLAassistant
Copy link

CLAassistant commented Nov 6, 2020

CLA assistant check
All committers have signed the CLA.

@anthonynsimon
Copy link
Contributor

Hey this looks awesome! Thanks for proposing these changes, I will checkout the code in the coming days.

Btw regarding marking the translations as "machine translated", you could use the tagging feature to add some tags automatically to those translations if that's what you're looking for. Should be pretty straightforward.

@haringsrob
Copy link
Author

Ah that is an interesting take indeed. I will check that out.

@arelstone
Copy link
Contributor

This is awesome.. Just what I need for my project. Already created an issue for this #156

@fnowacki
Copy link

@anthonynsimon what about this PR? :)

@anthonynsimon
Copy link
Contributor

@fnowacki I think this feature is great! However, I see many TODO's still open in the changes - would have to wait for those before merging :)

@haringsrob
Copy link
Author

I personally do not have much time at the moment to focus on this. I think the pr is open for changes :).

@anthonynsimon
Copy link
Contributor

@haringsrob thanks for the update, and no worries - I understand :)

@arelstone
Copy link
Contributor

Would be great if we could get someone to finish this. Really looking forward to this feature

@Alex-Giaquinto
Copy link

Has this every been implemented?

@evereq
Copy link
Member

evereq commented Oct 25, 2023

@Alex-Giaquinto / @fnowacki afraid it was not implemented. The PR indeed have a lot of TODOs that need to be resolved/improved etc. In addition, there are many more automatic translation options now, e.g. including OpenAI API, etc. I think we will need an approach with "providers" that allow translation services and implement that with some sort of plugin infrastructure, e.g. "Google Translate Plugin", "OpenAI Translate Plugin", etc. So it requires more work...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants