Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/upgrade jest #1211

Merged
merged 18 commits into from
Jun 30, 2023
Merged

Chore/upgrade jest #1211

merged 18 commits into from
Jun 30, 2023

Conversation

alexkuc
Copy link
Contributor

@alexkuc alexkuc commented Jun 29, 2023

Fixes #1210

@alexkuc alexkuc self-assigned this Jun 29, 2023
@github-actions github-actions bot added C: assets 💎 category C: build process 🔨 category C: tests 🧪 category D: Packages 📦 domain: Barista Packages labels Jun 29, 2023
@alexkuc alexkuc added T: chore 🧹 type: REPO - maintenance P3: med priority 😐 priority: medium S1: new 👶🏻 status and removed C: build process 🔨 category C: assets 💎 category S4: in progress 🚧 status labels Jun 29, 2023
@alexkuc alexkuc force-pushed the CHORE/upgrade-jest branch 12 times, most recently from 0a2017d to 7eadf08 Compare June 29, 2023 22:43
@alexkuc alexkuc force-pushed the CHORE/upgrade-jest branch 2 times, most recently from 39c177e to 33df7ff Compare June 29, 2023 22:57
@alexkuc alexkuc force-pushed the CHORE/upgrade-jest branch 5 times, most recently from efe7585 to 7095718 Compare June 30, 2023 00:57
@alexkuc alexkuc marked this pull request as ready for review June 30, 2023 01:12
@alexkuc alexkuc requested a review from tn3rb June 30, 2023 01:12
@alexkuc alexkuc mentioned this pull request Jun 30, 2023
Closed
tn3rb
tn3rb approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@tn3rb tn3rb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok 👍🏻

.github/workflows/pr-checks.yml
@@ -56,6 +56,8 @@ jobs:
- name: Run ${{ matrix.task }}
# Run the task only if JS is affected.
if: ${{ needs.what-is-hit.outputs.js == 'true' }}
env:
NODE_OPTIONS: '--max-old-space-size=4096'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

max-old-space-size ??? 😆

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the docs

Sets the max memory size of V8's old memory section. As memory consumption approaches the limit, V8 will spend more time on garbage collection in an effort to free unused memory.

https://nodejs.org/api/cli.html#--max-old-space-sizesize-in-megabytes

No idea what is "old memory section" though…

jest.config.ts
import { getDomains, getPackages } from './config/workspaces';
import type { TsJestTransformerOptions } from 'ts-jest';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool 👍🏻

@alexkuc alexkuc merged commit 5697eb5 into master Jun 30, 2023
12 checks passed
@alexkuc alexkuc deleted the CHORE/upgrade-jest branch June 30, 2023 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tn3rb tn3rb tn3rb approved these changes

Assignees

@alexkuc alexkuc

Labels
C: assets 💎 category C: automation & deployment ⚙️ category C: build process 🔨 category C: tests 🧪 category D: Packages 📦 domain: Barista Packages P3: med priority 😐 priority: medium S11: completed 🚀 status T: chore 🧹 type: REPO - maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chore: upgrade jest to latest version
3 participants
@alexkuc @tn3rb @eeteamcodebase