Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: split charger into current- and power controllers #7338

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Refactor: split charger into current- and power controllers #7338

wants to merge 9 commits into from
+828 −487

Conversation

andig
Copy link
Member

@andig andig commented Apr 10, 2023 •
edited

This PR is an investigation into splitting chargers into:

  • CurrentController: typically wall boxes
  • PowerController: typically heating devices, some chargers (ChargeX)
  • no controller ability beyond on/off: switch sockets

TODO

  • move all current control and phase switching logic from Loadpoint to core.currentController
  • refactor switchSocket to declare required power and remove Controller interfaces
  • think about refactoring ChargeState as part of Charger, potentially separate PR

Refs #6301, #7207

@andig andig added the infrastructure Basic functionality label Apr 10, 2023
@andig andig self-assigned this Apr 10, 2023
@andig andig marked this pull request as draft April 10, 2023 11:21
@github-actions github-actions bot added the stale Outdated and ready to close label May 1, 2023
@github-actions github-actions bot closed this May 7, 2023
@andig andig reopened this May 7, 2023
@github-actions github-actions bot removed the stale Outdated and ready to close label May 8, 2023
@github-actions github-actions bot added the stale Outdated and ready to close label Jun 10, 2023
@andig andig mentioned this pull request Jun 14, 2023
Closed
@github-actions github-actions bot closed this Jun 15, 2023
@andig andig added backlog Things to do later and removed stale Outdated and ready to close labels Jun 15, 2023
@andig andig reopened this Jun 15, 2023
@andig andig mentioned this pull request Aug 10, 2023
Closed
@andig andig mentioned this pull request Dec 26, 2023
Merged
@andig andig mentioned this pull request Apr 3, 2024
Merged
12 tasks
@maatinh
Copy link
Sponsor

maatinh commented Apr 25, 2024

Amperfied solar.connect kann auch mit Leistung statt Strom gesteuert werden und schaltet darüber auch selbstständig zwischen 1P/3P.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@andig andig

Labels
backlog Things to do later infrastructure Basic functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andig @maatinh