Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ford: fix auth api #13866

Merged
merged 5 commits into from May 16, 2024
Merged

Ford: fix auth api #13866

merged 5 commits into from May 16, 2024

Conversation

andig
Copy link
Member

@andig andig commented May 11, 2024

Fix #13845

@andig andig added the bug Something isn't working label May 11, 2024
Copy link
Sponsor Collaborator

@GrimmiMeloni GrimmiMeloni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Sponsor

@Sassar88 Sassar88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small optimization offers, otherwise it looks good :) thanks for fixing it

vehicle/ford/identity.go Outdated Show resolved Hide resolved
vehicle/ford/identity.go Outdated Show resolved Hide resolved
vehicle/ford/identity.go Show resolved Hide resolved
@andig
Copy link
Member Author

andig commented May 15, 2024

Did anyone actually test this? Doesn't work in my tests!

@Chris591
Copy link
Contributor

only tested it with parameter vehicle and it was working before for me.
tested with your changes and it's working as well.
tested with my default config as well and saw that the UI is showing it as well.

@andig
Copy link
Member Author

andig commented May 15, 2024

Question is: does it fix the problem?

@Chris591
Copy link
Contributor

Yes it's not working with the nightly version but with this branch.

@Chris591
Copy link
Contributor

But didn't tested any charging and updates or wake-up - but it nor offline anymore and show everything again.

vehicle/ford.go Outdated Show resolved Hide resolved
@andig andig merged commit 2e64361 into master May 16, 2024
6 checks passed
@andig andig deleted the fix/ford branch May 16, 2024 05:34
@beathoch
Copy link

evcc installed in home assistant. where can you find these files? The Ford integration basically works, but just not in evcc.

@GrimmiMeloni
Copy link
Sponsor Collaborator

You can put a new property into the configuration file called domain. For details check the diff in this PR in ford.yaml.

@beathoch
Copy link

You can put a new property into the configuration file called domain. For details check the diff in this PR in ford.yaml.

I can't find this ford.yaml file, where is it? under home assistant/custom_components/fordpass/ I have a fordpass_new.py file and in the folder home assistant I have the evcc.yaml file, but in there it can't find a option for the domain.

@andig
Copy link
Member Author

andig commented May 16, 2024

@beathoch use

evcc configure

as usual. Also as usual: you'll need the nightly version until the next release.

@beathoch
Copy link

@beathoch use

evcc configure

as usual. Also as usual: you'll need the nightly version until the next release.

ok, I understand, but how can I install it nightly in Home Assistant? I can't find an option for the nightly version.

@ifa8537
Copy link

ifa8537 commented May 17, 2024

Just updated to 0.126.3. But for some reason this has not fixed the problem with the Ford API login.

[main ] INFO 2024/05/17 11:11:05 evcc 0.126.3
[main ] INFO 2024/05/17 11:11:05 using config file: /etc/evcc.yaml
[main ] INFO 2024/05/17 11:11:05 starting ui and api at :7070
[db ] INFO 2024/05/17 11:11:06 using sqlite database: /var/lib/evcc/evcc.db
[main ] ERROR 2024/05/17 11:11:07 creating vehicle ev4 failed: cannot create vehicle type 'template': cannot create vehicle type 'ford': login failed: self-assert failed

If I add "domain: de" in the vehicle configuration I get the same error

@Chris591
Copy link
Contributor

yes as Ford change again something - also the Home Assistant AddIn isn't working anymore for me.

@andig
Copy link
Member Author

andig commented May 17, 2024

Doh: Once more, we'll need to wait for a solution. Laut TA2k/ioBroker.ford#35 könnte com wieder funktionieren?

@ifa8537
Copy link

ifa8537 commented May 17, 2024

Bei mir funktioniert weder com noch de

@miniluma
Copy link

Sorry to say, but after the update from 0.126.2 to 0.126.3, it stopped working.
No matter if I add "domain: com" or "... de" to my yaml.
With 0.126.2 It connected to my Mustang Mach-E properly just 10 minutes ago.

@djrepose
Copy link

vielleicht bin ich der einzige aber bei mir funktioniert der fix nicht?

@beathoch
Copy link

Bei mir funktioniert der fix ebenfalls nicht.

@evcc-io evcc-io locked as resolved and limited conversation to collaborators May 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ford wird nicht mehr erkannt / bei Ford blockiert? #13830
8 participants