Added EdgeTech Smartevse integrated charger controller

[swallage]

This pull request is used to add support for the highly Integrated Smartevse wallbox (charger controller) from EdgeTech.

[andig]

@swallage you are "decorating" optional behavior, but it is really always enabled:

	// features
	var (
		currentPower, chargedEnergy, totalEnergy func() (float64, error)
		currents                                 func() (float64, float64, float64, error)
		voltages                                 func() (float64, float64, float64, error)
		phases                                   func(int) error
	)

	currentPower = wb.currentPower
	chargedEnergy = wb.chargedEnergy
	totalEnergy = wb.totalEnergy
	currents = wb.currents
	voltages = wb.voltages
	phases = wb.phases1p3p

If your controller always supports these features we can simplify that significantly.

[andig]

Additional question: you have some logic for detecting optional behavior like

	if wb.cphwonlock {
                        ...
              
			if (binary.BigEndian.Uint16(cfg)&0x8) == 0 && err == nil {
				wb.log.WARN.Println("warning CpHWOnLock misconfiguration detected: board reports it has no CP hardware configured")
			}

This could be used to decorate the capabilities only when available. Wouldn't that be better than arbitrary warnings and user-selectable behavior?

[swallage]

@andig , thanks for following this up.
Yes, the charger always supports this > #13852 (comment) !

[swallage]

Additional question: you have some logic for detecting optional behavior like

	if wb.cphwonlock {
                        ...
              
			if (binary.BigEndian.Uint16(cfg)&0x8) == 0 && err == nil {
				wb.log.WARN.Println("warning CpHWOnLock misconfiguration detected: board reports it has no CP hardware configured")
			}

This could be used to decorate the capabilities only when available. Wouldn't that be better than arbitrary warnings and user-selectable behavior?

@andig ,
That would absolutely be better! This feature is optional and requires a special piece of hardware connected to the charger module. In the near future the feature will be build in and made optional. Does that answers your question?

[premultiply]

@swallage Thank you for your contribution.
I started a clean-up of the code a view days ago but hab no time to finish it yet.

See https://github.com/evcc-io/evcc/tree/device/smartevse

[swallage]

@premultiply , great, is really cleaner this way!

[andig]

Last comment: there's a fair bit of modbus traffic that is not error-checked like:

			wb.conn.WriteSingleRegister(smartEVSERegSettings, (binary.BigEndian.Uint16(cfg)&0xfffd)|1) // set Lockbit
			wb.conn.ReadInputRegisters(smartEVSERegExternalLock, 1)                                    // active lock setting (or relais in our case) by reading

[swallage]

@andig , that could be true, we are not Go-lang experts (Java is used internally). After the initial code is added to the main branch I can improve if you have a good example to error-check?! We have another improvement which I need to add later.