Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations: Improve language-specific formatting #13836

Closed
aerucu opened this issue May 9, 2024 · 8 comments · Fixed by #13880
Closed

Translations: Improve language-specific formatting #13836

aerucu opened this issue May 9, 2024 · 8 comments · Fixed by #13880
Assignees
Labels
bug Something isn't working ux User experience/ interface

Comments

@aerucu
Copy link
Contributor

aerucu commented May 9, 2024

Describe the bug

  1. In the Turkish translation, the percentage sign was written after the value in various places. However, the percentage sign must be written before the value.

2
3

  1. [footer.community]greenShareSub1 In Turkish, “solar, and battery storage” must come before “Power provided by”. Otherwise the sentence is not correct.

4

Steps to reproduce

  1. Set language to Türkçe
  2. Click on savings button in the footer.

...

Configuration details

Not relevant

Log details

Not relevant

What type of operating system are you running?

Linux

Version

v0.126.2

@andig
Copy link
Member

andig commented May 9, 2024

Please fix directly at https://hosted.weblate.org/projects/evcc/evcc/!

@andig andig closed this as completed May 9, 2024
@andig
Copy link
Member

andig commented May 9, 2024

Ah, sorry- it's not that easy. @naltatis how could we fix this?

@andig andig reopened this May 9, 2024
@andig andig added bug Something isn't working ux User experience/ interface labels May 9, 2024
@naltatis
Copy link
Member

naltatis commented May 9, 2024

@andig yes, we've previously discussed this in Slack. This is more of a general issue (I assume not only for Turkish and not only on this screen) where we have to change UI structure/layout based on language.

@aerucu in your screenshot you only flipped unit and number for the percentage value (% 88,6). We have other places in the UI. I assume these have to be adjusted as well, right?

Bildschirmfoto 2024-05-09 um 23 40 57

I'd suggest we collect all these places before making the necessary adjustments. I'll make the title of this issue a bit more general to indicate that.

@naltatis naltatis changed the title Incorrect spellings in the Turkish translation Translations: Improve language-specific formatting May 9, 2024
@naltatis
Copy link
Member

naltatis commented May 9, 2024

  1. [footer.community]greenShareSub1 In Turkish, “solar, and battery storage” must come before “Power provided by”. Otherwise the sentence is not correct.

@aerucu I don't see an issue here. In this place, we've named the placeholders pretty generic deliberately greenShareSub1 and greenShareSub2. The contents of both fields do not have to match the source translation order as long as the message stays correct. Feel free to flip the content if it makes more sense.

@aerucu
Copy link
Contributor Author

aerucu commented May 9, 2024

@aerucu in your screenshot you only flipped unit and number for the percentage value (% 88,6). We have other places in the UI. I assume these have to be adjusted as well, right?

@naltatis I have already flipped all the places that could be flipped in the Weblate.

@aerucu
Copy link
Contributor Author

aerucu commented May 9, 2024

@aerucu I don't see an issue here. In this place, we've named the placeholders pretty generic deliberately greenShareSub1 and greenShareSub2. The contents of both fields do not have to match the source translation order as long as the message stays correct. Feel free to flip the content if it makes more sense.

In Turkish, the content of the [footer.community]greenShareSub2 placeholder must be displayed first and then the content of the [footer.community]greenShareSub1 placeholder. Otherwise the sentence is not correct.

Then I flip the content in Weblate so that it is correct.

@aerucu
Copy link
Contributor Author

aerucu commented May 9, 2024

Done!

@StefanSchoof
Copy link
Contributor

Was curious what toLocaleString is doing with turkish percent and it works:

(3/4).toLocaleString("tr", {style: "percent"})

will produce "%75".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ux User experience/ interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants