Make the ENTRYPOINT source actually work #669
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…effective on container launch
|
This would be great to have. Could you look at why the 18.04 failed? |
|
I suspect this was due to the revoked key that had to be manually added before but now this was fixed in #671 I believe if you run it again it will succeed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, the Docker
ENTRYPOINTdoesn't source the$WORKSPACE/devel/setup.bashcausingrosrunnot to be available in the Docker container on launch.This change adds the export and source to
/root/.bashrcmaking sure that on launch the ROS environment is sourced andKALIBR_MANUAL_FOCAL_LENGTH_INITexported.Reopening a new PR as the old #666 was based on master