Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension improvements #550

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Extension improvements #550

wants to merge 7 commits into from

Conversation

cstrecht
Copy link
Contributor

@cstrecht cstrecht commented Dec 11, 2023

Why?

  • This pull request will introduce enhancements to the Iron Wallet browser extension, improving its visual appeal, making it more organised and "easy-to-read".

Before:

extension

At the moment:

Screenshot 2024-01-10 at 4 43 47 PM

Screenshot 2024-01-10 at 4 44 22 PM

@cstrecht cstrecht marked this pull request as ready for review January 10, 2024 16:23
@naps62
Copy link
Member

naps62 commented Apr 12, 2024

@cstrecht I see what you're going for here, but a lot of these changes seem very ad-hoc, and with some consistency issues (e.g. text alignment, margins etc look inconsistent)

My idea for this was to use a data display package (the one currently used), and eventually transition to share a component library with the desktop wallet, so we could keep coherence in terms of design.
at the moment, that would mean using MUI Material as well, instead of building our own

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants