Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

added broken test and supporting .sol and .json #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pointtoken
Copy link

Kumavis suggested I submit a PR with a broken test. That was a little tricky, since your policy doesn't allow commits with broken tests, so you'll have to rem back in the code to get it to fail. I went ahead and checked in the Solidity file. The json abi was generated with Truffle.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling b9792ab on pointtoken:abi_broken_test into 26649fd on ethjs:master.

@kumavis
Copy link

kumavis commented Sep 14, 2017

part of the question here is what is event.options supposed to be. is it the params given to creating a new filter? if so this is a potential bug as the generated params are not equivalent

from this PRs commented failing test:

const addEventWeb3 = SampleMathContractInstanceWeb3.addEvent({ a: 5 }, { fromBlock: 0, toBlock: 'latest' });
const addEvent = SampleMathContractInstance.addEvent({ a: 5 }, { fromBlock: 0, toBlock: 'latest' });
assert.equal(addEvent.options, addEventWeb3.options);

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants