Remove redundant prerequisite steps from the default optimizer sequence #15092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameel
force-pushed
the
remove-redundant-prerequisites-from-default-sequence
branch
from
80c293d
to
1462e34
Compare
|
Rebased on top of the new sequence. |
r0qs
reviewed
May 15, 2024
|
No, we don't really document the default sequence. We need a changelog entry though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
ghosteps are hard-coded as prerequisites, there's not much point in having them in the default sequence. All other steps are supposed to preserve these properties.For now this is just to verify that removing them does not really change generated bytecode in a meaningful way.
If this is true, we might consider merging it, though that would probably be better done only after rebasing it on the new sequence (#15030). Otherwise merging it would just revert it.