Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move python dependencies to docker images #15060

Merged
merged 2 commits into from Apr 26, 2024
Merged

Conversation

r0qs
Copy link
Member

@r0qs r0qs commented Apr 26, 2024

Replaces #14997
Fixes part of #14847
Depends on #15059

@r0qs r0qs added build system 🏗️ has dependencies The PR depends on other PRs that must be merged first labels Apr 26, 2024
@r0qs r0qs force-pushed the move-python-deps-to-docker-imgs branch from 28a4cf9 to 7109e18 Compare April 26, 2024 15:59
@r0qs r0qs marked this pull request as ready for review April 26, 2024 16:11
cameel
cameel previously approved these changes Apr 26, 2024
Copy link
Member

@cameel cameel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If CI passes, it's good to go.

Base automatically changed from add-python-pkgs-buildpack-deps to develop April 26, 2024 17:21
@r0qs r0qs dismissed cameel’s stale review April 26, 2024 17:21

The base branch was changed.

r0qs and others added 2 commits April 26, 2024 19:21
Co-authored-by: Tim-Tscheppe <timothy.tscheppe@marquette.edu>
@r0qs r0qs force-pushed the move-python-deps-to-docker-imgs branch from 7109e18 to 21dbf83 Compare April 26, 2024 17:22
@r0qs r0qs enabled auto-merge April 26, 2024 17:23
@nikola-matic nikola-matic removed the has dependencies The PR depends on other PRs that must be merged first label Apr 26, 2024
@r0qs r0qs merged commit 2c3fc90 into develop Apr 26, 2024
73 checks passed
@r0qs r0qs deleted the move-python-deps-to-docker-imgs branch April 26, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants