Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Add support to run yul optimizer assembly test. #15009

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

aarlt
Copy link
Member

@aarlt aarlt commented Apr 11, 2024

This is needed in the context of ethdebug. I will need to write some tests on how optimiser steps are dealing with the debug attributes defined by #14857. The ideas is to implement different PRs per optimiser step on top of #14969, where this PR will enable the visualisation how these debug attributes got potentially merged - depending on the optimiser step.

For context, see e.g. #15087.

@cameel cameel mentioned this pull request Apr 12, 2024
Copy link
Member

@cameel cameel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this is pretty much an exact copy of YulOptimizerTest.h at this point, so I assume it's unfinished. What is actually the idea behind this test? Just displaying the assembly next to the optimized Yul or something more?

test/libyul/YulOptimizerAssemblyTest.cpp Show resolved Hide resolved
test/InteractiveTests.h Outdated Show resolved Hide resolved
@aarlt aarlt force-pushed the add_yul_optimizer_assembly_test branch from e953eca to 917cec1 Compare April 18, 2024 21:01
@aarlt aarlt force-pushed the add_yul_optimizer_assembly_test branch 4 times, most recently from 8a4d556 to de39abd Compare April 22, 2024 15:19
@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label May 7, 2024
@ethereum ethereum deleted a comment from github-actions bot May 7, 2024
@aarlt aarlt removed the stale The issue/PR was marked as stale because it has been open for too long. label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants