Fix docs for string/hex string literal conversion to bytesNN #15002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to the Solidity compiler! A team member will follow up shortly. If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother. If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix. |
pcw109550
force-pushed
the
pcw109550/docs-fix-string-literal-conversion-to-bytesXX
branch
from
276b3dd
to
c76f3b7
Compare
There was a problem hiding this comment.
Hi @pcw109550, please squash the commits into one when you address my comments, and we should be able to merge then.
pcw109550
force-pushed
the
pcw109550/docs-fix-string-literal-conversion-to-bytesXX
branch
2 times, most recently
from
41f8bb3
to
3444ff4
Compare
pcw109550
force-pushed
the
pcw109550/docs-fix-string-literal-conversion-to-bytesXX
branch
from
3444ff4
to
04b220d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implicit/Explicit conversion from string/hex string literals to bytesNNs are allowed. hex_string_to_bytesNN_different_size_explicit.sol shows that these conversions are allowed.
Fixed wrong documentation of type conversion.
Added test case for checking implicit conversion from string/hex string literals to bytesNNs.