Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass vector of SMT expressions to SymbolicFunctionVariable function operator by const ref instead of by value. #14981

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion libsolidity/formal/SymbolicVariables.cpp
Expand Up @@ -203,7 +203,7 @@ smtutil::Expression SymbolicFunctionVariable::increaseIndex()
return m_abstract.currentValue();
}

smtutil::Expression SymbolicFunctionVariable::operator()(std::vector<smtutil::Expression> _arguments) const
smtutil::Expression SymbolicFunctionVariable::operator()(std::vector<smtutil::Expression> const& _arguments) const
{
return m_declaration(_arguments);
}
Expand Down
4 changes: 2 additions & 2 deletions libsolidity/formal/SymbolicVariables.h
Expand Up @@ -62,7 +62,7 @@ class SymbolicVariable
virtual smtutil::Expression resetIndex();
virtual smtutil::Expression setIndex(unsigned _index);
virtual smtutil::Expression increaseIndex();
virtual smtutil::Expression operator()(std::vector<smtutil::Expression> /*_arguments*/) const
virtual smtutil::Expression operator()(std::vector<smtutil::Expression> const& /*_arguments*/) const
{
solAssert(false, "Function application to non-function.");
}
Expand Down Expand Up @@ -177,7 +177,7 @@ class SymbolicFunctionVariable: public SymbolicVariable
smtutil::Expression setIndex(unsigned _index) override;
smtutil::Expression increaseIndex() override;

smtutil::Expression operator()(std::vector<smtutil::Expression> _arguments) const override;
smtutil::Expression operator()(std::vector<smtutil::Expression> const& _arguments) const override;

private:
/// Creates a new function declaration.
Expand Down