Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syntax: Reject semver version individual parts in strings #14886

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

syntax: Reject semver version individual parts in strings #14886

wants to merge 3 commits into from
+29 −1

Commits on Feb 26, 2024

  1. syntax: Reject semver version individual parts in strings 

    This seems like an oversight from the initial implementation that
supported versions such as "^0.4.0" but which now has a side effect of
converting individual string literals to their token values, allowing
for syntax such as:
- `0 "." 8 "." 0`
- '"1".2.3"`
- '"1"."2"."3"`

and so on.

This fix aims to address the unintentional acceptance of such syntax,
primarily to simplify the logic of external parsers and to more clearly
establish what constitutes valid syntax for a crucial element
like the version pragma statement.
    @Xanewok
    Xanewok committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    ae428cd View commit details
    Browse the repository at this point in the history

  2. Add tests

    @Xanewok
    Xanewok committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    fc93da2 View commit details
    Browse the repository at this point in the history

  3. fix: Handle properly m_pos pointing after the last part after parsing

    @Xanewok
    Xanewok committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    957b1ed View commit details
    Browse the repository at this point in the history