New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stack shuffling refactor #14851
base: develop
Are you sure you want to change the base?
Stack shuffling refactor #14851
Conversation
4102ad6
to
5f291e4
Compare
5f291e4
to
16e9a74
Compare
c8aceb0
to
cc502d2
Compare
cc502d2
to
700c5fa
Compare
700c5fa
to
b93d4ac
Compare
b93d4ac
to
aba9a72
Compare
Benchmarks results:
|
So only |
It would be interesting to see it benchmarked the way I did in #14854 (comment) This would show pure compilation time on some actual projects (I chose Uniswap v4 and Seaport since their latest versions compile without any workarounds) but with less variance than we see in CI. Or at least in a way that makes it easier to run multiple times and average the results. |
On the topic of the PR itself - I tried to review it but the diff is almost useless due to all the moved code. It also has no description or changelog and commit descriptions are not very informative, so I'm not really sure what to expect here. The title sounds as if you were just making the code nicer but it does not seem to be all that you're doing here. If you could separate the refactors from actual functional changes, it would be much easier to review. |
No description provided.