Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Updating copyright year to 2024 #14849

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

githubfromgui
Copy link

This PR has the goal of simply changing the copyright year from 2023 to 2024.

Plus, I would suggest to update the following from the soliditylang.org website:

  • 2023 date in the website footer:

image

  • Twitter logo to X logo.

Copy link

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

@githubfromgui githubfromgui changed the title Updating copyright year to 2024 [DOCS] Updating copyright year to 2024 Feb 13, 2024
@cameel
Copy link
Member

cameel commented Feb 13, 2024

I don't think we really need the year range there. It does not matter for copyright purposes, it's mostly informational and for that information the timestamps in the repo are really the canonical source. I'd definitely drop the upper date so that we don't have to bump it constantly, but maybe we should follow curl's example and drop the dates completely.

I also don't think we need to hurry too much with following Twitter's weird branding decisions. Their current branding is confusing to the point that just showing the name or logo is ambiguous without some kind of clarification. I'd just not worry about it, keep the old branding and just wait and see what they settle on in the long term.

@githubfromgui
Copy link
Author

I don't think we really need the year range there. It does not matter for copyright purposes, it's mostly informational and for that information the timestamps in the repo are really the canonical source. I'd definitely drop the upper date so that we don't have to bump it constantly, but maybe we should follow curl's example and drop the dates completely.

I also don't think we need to hurry too much with following Twitter's weird branding decisions. Their current branding is confusing to the point that just showing the name or logo is ambiguous without some kind of clarification. I'd just not worry about it, keep the old branding and just wait and see what they settle on in the long term.

I can agree that maybe the best solution is to completely remove the year range from code docs and the website footer, however if its kept, I think it should be aligned with the current year.

The same goes for the Twitter/X logo, it's just a matter of branding and attention to details. IMO seeing 2023 and an old brand trademark feels like the project isn't being continued.

Just for more context, see a few examples where this info is up to date:

Stripe.com (date)
Paypal (date)
Vercel (date + logo)

However, Uber isn't (- logo) 😶

@aarlt
Copy link
Member

aarlt commented Feb 19, 2024

I don't think we really need the year range there. It does not matter for copyright purposes, it's mostly informational and for that information the timestamps in the repo are really the canonical source. I'd definitely drop the upper date so that we don't have to bump it constantly, but maybe we should follow curl's example and drop the dates completely.

I also don't think we need to hurry too much with following Twitter's weird branding decisions. Their current branding is confusing to the point that just showing the name or logo is ambiguous without some kind of clarification. I'd just not worry about it, keep the old branding and just wait and see what they settle on in the long term.

Yeah, maybe we should really just drop the dates completely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants