Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tests from test/libsolidity/ViewPureChecker.cpp to syntaxTests/viewPureChecker #14805

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

AbhinavMir
Copy link

Potential fix for #14796

environment_access_test.sol tests the correct classification of environment access operations in view and pure functions.

Signed-off-by: Abhinav Srivastava <atg271@gmail.com>
Copy link

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

@cameel
Copy link
Member

cameel commented Jan 26, 2024

Sorry, but this change does not address the issue at all.

The idea is to take all tests from test/libsolidity/ViewPureChecker.cpp, create equivalent syntax tests and remove the .cpp file.

@AbhinavMir
Copy link
Author

Hi @cameel , this is still in the works. I've posted a question on the original issue, posting it here for convenience: Would the test runner pick up these tests automatically or do I need to index the new tests somewhere?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants