Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation about codehash behaviour according to EIP-1052 and EIP-161 #14793

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ustas-eth
Copy link

@ustas-eth ustas-eth commented Jan 21, 2024

Fixes #14794 by adding a warning for the codehash usage.

Copy link

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

@ustas-eth
Copy link
Author

Please, see the following issue: #14794

Copy link
Member

@r0qs r0qs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @ustas-eth, I just have one comment ;)

docs/types/value-types.rst Outdated Show resolved Hide resolved
@r0qs r0qs changed the title Update value-types.rst Update documentation about codehash behaviour according to EIP-1052 and EIP-161 Feb 5, 2024
docs/types/value-types.rst Outdated Show resolved Hide resolved
@r0qs
Copy link
Member

r0qs commented Apr 26, 2024

Thanks @ustas-eth. Could you please just squash the commits and rebase with the develop branch? :)

@ustas-eth
Copy link
Author

@r0qs I did, but I'm not sure if the result is what you expected. I'm not very proficient with git :')

… state

Co-authored-by: r0qs <rodrigo.saramago@protonmail.com>
@r0qs
Copy link
Member

r0qs commented Apr 26, 2024

@r0qs I did, but I'm not sure if the result is what you expected. I'm not very proficient with git :')

haha no problem, I fixed it for you ;)

Thanks a lot for your contribution!

@r0qs r0qs requested a review from cameel April 26, 2024 16:51
Copy link
Member

@r0qs r0qs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm kinda of approving myself here, so @cameel, please take a look when you have some time ;)

@r0qs r0qs requested a review from mehtavishwa30 April 26, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add nuances of .codehash usage to the documentation
3 participants