External tests script refactor #14064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r0qs
commented
Mar 22, 2023
r0qs
force-pushed
the
external-tests-refactor
branch
from
3486a83
to
5468baf
Compare
nikola-matic
previously approved these changes
Apr 11, 2023
There was a problem hiding this comment.
Squash squash squash.
Some of the things I guess could be written in a more 'Pythonic' way, but honestly, it just makes the code less readable to me, so I'm perfectly fine with the way it is currently. Also, seeing as this doesn't really impact the CI at the moment, I'm fine with merging this and then improving incrementally when needed.
r0qs
force-pushed
the
external-tests-refactor
branch
from
26fe47f
to
f1a27c2
Compare
Merged
cameel
reviewed
Apr 25, 2023
cameel
reviewed
Apr 26, 2023
r0qs
force-pushed
the
external-tests-refactor
branch
from
d47b089
to
9024e52
Compare
cameel
reviewed
Apr 27, 2023
r0qs
force-pushed
the
external-tests-refactor
branch
from
9024e52
to
957a727
Compare
cameel
reviewed
Apr 28, 2023
r0qs
force-pushed
the
external-tests-refactor
branch
from
957a727
to
b754128
Compare
Co-authored-by: Kamil Śliwak <kamil.sliwak@codepoets.it>
r0qs
force-pushed
the
external-tests-refactor
branch
from
b754128
to
28a9592
Compare
cameel
approved these changes
Apr 28, 2023
r0qs
commented
Apr 28, 2023
| raise ExternalTestNotFound( | ||
| f"External test(s) not found: {', '.join(unrecognized_tests)}" | ||
| ) | ||
| run_test_scripts( |
There was a problem hiding this comment.
Just noticed that without the return this will now always raise the ExternalTestNotFound exception. Will push the fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #13873 (comment).
The script allows running external tests by name (e.g. one, multiple or all external tests) and automatically detects their configuration scritps. I prefered to detect the configuration scripts automatically instead of hardcode the available external tests, to allow us to add/remove new tests without the need to modify the runner script.
The idea is that this script will be used as part of PR #13873 to run the external tests locally or via CI.