Add extra test case for event inheritance Natspec #14048
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikola-matic
added
the
has dependencies
Merged
|
This pull request is stale because it has been open for 14 days with no activity. |
github-actions
bot
added
the
stale
nikola-matic
removed
the
stale
cameel
requested changes
Apr 12, 2023
There was a problem hiding this comment.
This is not really what I meant but I guess it does answer the question :) Defining the same event in multiple bases seems to be disallowed and that was the case I was worried about. So we don't need such a test just yet. At least not until we relax that restriction (which could be soon).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A #13391 related addition for #10996.
Depends on #10996.