multi-module build #388
Open
multi-module build #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main aim here is to remove log4j and main classes from compile scope in the core library. This will help integrate ethereumj-core as a library into projects that don’t choose to use log4j and want to use a different logging framework to back slf4j. Problems encountered: `org.ethereum.util.AdvancedDeviceUtils` uses log4j to dynamically change the logging config. There was no resolution other than to remove this.
|
@Nashatyrev, as discussed on Here’s my first attempt at this. I’m far from a Gradle expert—happy to hear suggestions for improvements. |
|
Many thanks for this PR! I like this modular approach, though need to discuss with the team if we have any fallbacks here |
the build task needs `mainClassName` to be defined
|
I think there’s probably room for further improvement, but I got this far enough to accomplish my original goal of tidying up what was on the classpath for the core library. |
|
Resolved the merge conflict in 30b78d4 |
|
@romanman I believe you were going to comment on this PR |
|
Trying to master the Trivial pursuit of coding and creating an equal opportunity for all to access funds at time of need |
|
这是来自QQ邮箱的假期自动回复邮件。您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main aim here is to remove log4j and main
classes from compile scope in the core library.
This will help integrate ethereumj-core as a library
into projects that don’t choose to use log4j and
want to use a different logging framework to back
slf4j.
Problems encountered:
org.ethereum.util.AdvancedDeviceUtilsuses log4jto dynamically change the logging config. There was
no resolution other than to remove this.
update to gradle and wrapper script