chore: try add small optimizations to divide_polynomialcoeff #3722
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds three optimizations:
Replace
.insert(0,x)
with.append(x)
and then a.reverse
. Inserting at the first index on each loop causes every item in the list to be shifted down by one at each loop iteration.return [x % BLS_MODULUS for x in o]
toreturn o
. The values ofo
should already be reduced since they are coming from thediv
function.(a - b + modulus) becomes (a + (modulus - b)) - This mainly a nit, as the order of operations is not entirely clear.