macOS support for running individual generators #3568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The workarounds in `setup.py` to install `ruamel.yaml` and `marko` don't
work when starting from a clean build, e.g.:
```sh
make clean
git clean -dfx
make preinstallation
make install_test
make pyspec
make -j gen_fork_choice
```
This results in error:
```
generator fork_choice started
Processing /consensus-specs
Installing build dependencies ... done
Getting requirements to build wheel ... error
error: subprocess-exited-with-error
× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> [30 lines of output]
/consensus-specs/tests/generators/fork_choice/venv/bin/python3.11: No module named pip
Traceback (most recent call last):
File "<string>", line 45, in <module>
ModuleNotFoundError: No module named 'ruamel'
```
Adding `--no-use-pep517` disables some environment isolation for `pip`,
and makes this work once more on macOS. `--no-use-pep517` requires prior
installation of `setuptools` and `wheel`.
```
% sw_vers
ProductName: macOS
ProductVersion: 14.2.1
BuildVersion: 23C71
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workarounds in
setup.pyto installruamel.yamlandmarkodon't work when starting from a clean build, e.g.:This results in error:
Adding
--no-use-pep517disables some environment isolation forpip, and makes this work once more on macOS.--no-use-pep517requires prior installation ofsetuptoolsandwheel.