Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use strutils.escape to handle special characters in KZG directory paths in Nim bindings #412

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

Copy link
Member

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh that's a good thing to fix. LGTM 👍

@tersec would you like us to cut a new v1.0.1 release after merging this?

@jtraglia jtraglia merged commit 1ef67c1 into ethereum:main Mar 26, 2024
35 checks passed
@tersec tersec deleted the nim-handle-special-path-chars branch March 26, 2024 19:28
@tersec
Copy link
Contributor Author

tersec commented Mar 26, 2024

Oh that's a good thing to fix. LGTM 👍

@tersec would you like us to cut a new v1.0.1 release after merging this?

That would be useful, yes

@jtraglia
Copy link
Member

Okay no problem. I'd like to confirm it with the team first. Should have it out by tomorrow morning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants