Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed default builder boost #438

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fredriksvantes
Copy link
Contributor

Removed "default" boost wording where the default value should be a fixed to 100 on clients as this has been changed to 90 on multiple clients.

Removed "default" boost wording where the default value should be a fixed to 100 on clients as this has been changed to 90 on multiple clients.
@mcdee
Copy link
Contributor

mcdee commented Mar 29, 2024

We can't just remove the default, it's already part of the released spec and it's possible that validator clients are sending in requests without this value and expecting it to be 100.

Given that at this point there are client releases that have altered this value I think the best bet would be to state that if the parameter is not supplied then it defaults to whatever value is configured in the beacon node. Although that doesn't adhere to the spec as-is, and so is still a spec change, I think it is the closest that we will get when taking reality into account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants