fix: plasma finalize

[0xyjk]

Description

When one block has multiple plasma commitment, the ExpireChallenges for loop will only execute once, which cause activeComms didn't get poped, and the s.finalized will never get updated

[coderabbitai]

Walkthrough

Walkthrough

The recent changes focus on enhancing the op-plasma module's damgr_test.go file. These updates introduce a new test scenario for advancing L1 origin with multiple commitments in a single block. Additionally, adjustments were made to two mock functions within the same file to improve their behavior by changing the return types to pointers. These modifications aim to boost the accuracy and effectiveness of the test suite.

Changes

Files	Change Summary
op-plasma/damgr_test.go	Added test for advancing L1 origin with multiple commitments in the same block.
op-plasma/damgr_test.go	Modified mockL1Fetcher methods to return pointers (&info and ref) instead of values.
op-service/testutils/mock_eth_client.go	Updated ExpectFetchReceipts method in MockEthClient struct to remove Once() call.

---

Recent Review Details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f3f2d44 and 572a736.

Files selected for processing (1)

• op-service/testutils/mock_eth_client.go (1 hunks)

Additional comments not posted (1)

op-service/testutils/mock_eth_client.go (1)

106-106: Ensure the removal of .Once() aligns with intended test scenarios.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[tynes]

We really should have a falling test case that is fixed by this patch

[coderabbitai]

Actionable comments posted: 1

[trianglesphere]

Nice addition with the test. I confirmed that removing the fixes causes the test to fail.

[trianglesphere]

@0xyjk op-node tests are failing. I'm able to replicate inside op-node folder with go test ./...

[0xyjk]

@0xyjk op-node tests are failing. I'm able to replicate inside op-node folder with go test ./...

it's fixed @trianglesphere