Skip to content

Commit

Permalink
op-node: Add flag categories (#9629)
Browse files Browse the repository at this point in the history
* op-node: Add flag categories

* op-node: Order categories & move some beacon flags to L1 RPC
  • Loading branch information
trianglesphere committed Feb 22, 2024
1 parent af1d482 commit f707883
Show file tree
Hide file tree
Showing 10 changed files with 305 additions and 188 deletions.
2 changes: 1 addition & 1 deletion op-batcher/flags/flags.go
Expand Up @@ -130,7 +130,7 @@ func init() {
optionalFlags = append(optionalFlags, oppprof.CLIFlags(EnvVarPrefix)...)
optionalFlags = append(optionalFlags, txmgr.CLIFlags(EnvVarPrefix)...)
optionalFlags = append(optionalFlags, compressor.CLIFlags(EnvVarPrefix)...)
optionalFlags = append(optionalFlags, plasma.CLIFlags(EnvVarPrefix)...)
optionalFlags = append(optionalFlags, plasma.CLIFlags(EnvVarPrefix, "")...)

Flags = append(requiredFlags, optionalFlags...)
}
Expand Down
4 changes: 2 additions & 2 deletions op-bootnode/flags/flags.go
Expand Up @@ -13,8 +13,8 @@ import (
const envVarPrefix = "OP_BOOTNODE"

var Flags = []cli.Flag{
opflags.CLINetworkFlag(envVarPrefix),
opflags.CLIRollupConfigFlag(envVarPrefix),
opflags.CLINetworkFlag(envVarPrefix, ""),
opflags.CLIRollupConfigFlag(envVarPrefix, ""),
}

func init() {
Expand Down
2 changes: 1 addition & 1 deletion op-conductor/flags/flags.go
Expand Up @@ -112,7 +112,7 @@ func init() {
optionalFlags = append(optionalFlags, oplog.CLIFlags(EnvVarPrefix)...)
optionalFlags = append(optionalFlags, opmetrics.CLIFlags(EnvVarPrefix)...)
optionalFlags = append(optionalFlags, oppprof.CLIFlags(EnvVarPrefix)...)
optionalFlags = append(optionalFlags, opflags.CLIFlags(EnvVarPrefix)...)
optionalFlags = append(optionalFlags, opflags.CLIFlags(EnvVarPrefix, "")...)

Flags = append(requiredFlags, optionalFlags...)
}
Expand Down
2 changes: 1 addition & 1 deletion op-node/cmd/networks/cmd.go
Expand Up @@ -18,7 +18,7 @@ var Subcommands = []*cli.Command{
Name: "dump-rollup-config",
Usage: "Dumps network configs",
Flags: []cli.Flag{
opflags.CLINetworkFlag(flags.EnvVarPrefix),
opflags.CLINetworkFlag(flags.EnvVarPrefix, ""),
},
Action: func(ctx *cli.Context) error {
logCfg := oplog.ReadCLIConfig(ctx)
Expand Down

0 comments on commit f707883

Please sign in to comment.