Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DreyerX Icon #4965

Closed
wants to merge 14 commits into from
Closed

Update DreyerX Icon #4965

wants to merge 14 commits into from

Conversation

dreyerx
Copy link
Contributor

@dreyerx dreyerx commented May 1, 2024

I have tried to display the icon on the chainlist.org page, but to no avail. This is likely because the code to access the file is incorrect.

If this doesn't work, is there another way to display the icon on the chainlist.org page?

@dreyerx
Copy link
Contributor Author

dreyerx commented May 11, 2024

Hey @ligi, can you review this pull request?

@billalxcode
Copy link
Contributor

Please accept this pull request @ligi

Copy link
Member

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old code seems to be correct:
ipfs add

_data/iconsDownload/QmTGjVbiSdHYhjzpeqzY6fGwGiLQuEa2hW7irD75sUSx9e
added QmTGjVbiSdHYhjzpeqzY6fGwGiLQuEa2hW7irD75sUSx9e QmTGjVbiSdHYhjzpeqzY6fGwGiLQuEa2hW7irD75sUSx9e

also the icon is shown:

image

@billalxcode
Copy link
Contributor

But it doesn't work if I check it on chainlist.org

image

@ligi
Copy link
Member

ligi commented May 13, 2024

then they should fix that

@ligi ligi closed this May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants