-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix performance for large pads #4267
Conversation
491c5b5
to
c6dead9
Compare
@seballot is an absolute ninja :D Well done man! I'm going to merge but things to note:
Probably due to sketchy test. But weirdly azlso seeing:
and obviously Firefox 52 is still crashing due to responsiveness.js, so I'm gonna run the test again, see if those OSX errors go and then merge. |
Must have been a glitch in the underpants. Merging! Thanks @seballot . @joassouza please confirm you get a better UX now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think fastRun.sh was committed by accident @seballot ?? If you can remove I can merge :)
bin/fastRun.sh
Outdated
@@ -7,16 +7,17 @@ | |||
# of what to do, please execute bin/installDeps.sh once before running this | |||
# script. | |||
|
|||
set -eu | |||
pecho() { printf %s\\n "$*"; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be included in this PR?
This old rule was conflicting with new css rules introduced in 1.8.4
Due to layout trashing when calculating new heights
c6dead9
to
2cd0a0f
Compare
Hi ! fastRun was not an accident, but I removed it so the pull request is only focused on the performance thing |
Well done @seballot! I've tested here and works amazingly! |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Refs #4228