Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix performance for large pads #4267

Merged
merged 2 commits into from
Sep 8, 2020
Merged

Conversation

seballot
Copy link
Contributor

@seballot seballot commented Sep 8, 2020

Refs #4228

@JohnMcLear
Copy link
Member

@seballot is an absolute ninja :D Well done man!

I'm going to merge but things to note:

  1. Now seeing a Mac / Safari error:
[safari OS X 10.15 13.1] responsiveness.js

[safari OS X 10.15 13.1]   Responsiveness of Editor

[safari OS X 10.15 13.1]     -> FAILED : Fast response to keypress in pad with large amount of contents Error: Error:

[safari OS X 10.15 13.1]      expected 354 to be below 300 (http://localhost:9001/tests/frontend/lib/expect.js:99)

[safari OS X 10.15 13.1]     (http://localhost:9001/tests/frontend/lib/mocha.js:64)

[safari OS X 10.15 13.1] 

Probably due to sketchy test. But weirdly azlso seeing:

[safari OS X 10.15 13.1] timeslider_numeric_padID.js

[safari OS X 10.15 13.1]   timeslider

[safari OS X 10.15 13.1]     -> FAILED : Makes sure the export URIs are as expected when the padID is numeric Error: 

[safari OS X 10.15 13.1]     Error: expected -1 to not equal -1 (http://localhost:9001/tests/frontend/lib/expect.js:99)

[safari OS X 10.15 13.1]     (http://localhost:9001/tests/frontend/lib/mocha.js:64)

and obviously Firefox 52 is still crashing due to responsiveness.js, so I'm gonna run the test again, see if those OSX errors go and then merge.

@JohnMcLear
Copy link
Member

[safari OS X 10.15 13.1] FINISHED - 107 tests passed, 0 tests failed, 20  pending, duration: 7:4

Must have been a glitch in the underpants.

Merging! Thanks @seballot . @joassouza please confirm you get a better UX now :)

Copy link
Member

@JohnMcLear JohnMcLear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think fastRun.sh was committed by accident @seballot ?? If you can remove I can merge :)

bin/fastRun.sh Outdated
@@ -7,16 +7,17 @@
# of what to do, please execute bin/installDeps.sh once before running this
# script.

set -eu
pecho() { printf %s\\n "$*"; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be included in this PR?

This old rule was conflicting with new css rules introduced in 1.8.4
Due to layout trashing when calculating new heights
@seballot
Copy link
Contributor Author

seballot commented Sep 8, 2020

Hi ! fastRun was not an accident, but I removed it so the pull request is only focused on the performance thing

@joassouza
Copy link
Contributor

Well done @seballot! I've tested here and works amazingly!
Thanks for your work, I really appreciate that
Merci :)

@sonarcloud
Copy link

sonarcloud bot commented Sep 8, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.8% 2.8% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants