Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GROMACS [GH200] #94

Merged
merged 48 commits into from
Jun 1, 2024
Merged

GROMACS [GH200] #94

merged 48 commits into from
Jun 1, 2024

Conversation

kanduri
Copy link
Collaborator

@kanduri kanduri commented May 13, 2024

Got a working GROMACS 2023.3 with MPICH and CUDA. Now trying with newer 2024.1 versions. Will make new commits when that is working.

@kanduri
Copy link
Collaborator Author

kanduri commented May 15, 2024

cscs-ci run alps;system=santis;uarch=gh200;uenv=gromacs:2023
cscs-ci run alps;system=santis;uarch=gh200;uenv=gromacs:2024

@kanduri kanduri changed the title WIP: Gromacs santis GROMACS santis May 15, 2024
@kanduri
Copy link
Collaborator Author

kanduri commented May 15, 2024

GROMACS 2024.1 working with a newer Spack recipe.

Copy link
Member

@bcumming bcumming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

Regarding the selection of recipes:

  1. maintaining both a 2023 and 2024 recipe is high overhead. Because we go live in June 2024, you could just provide gromacs 2024?
  2. You provide separate recipes for gh200 and gh200-mpi
  • these could be consolidated to a single recipe, with two environments in the environments.yaml, and views gromacs and gromacs-mpi?

recipes/gromacs/2024/gh200-mpi/cache-config.yaml Outdated Show resolved Hide resolved
recipes/gromacs/2024/gh200/cache-config.yaml Outdated Show resolved Hide resolved
recipes/gromacs/2023/gh200-mpi/cache-config.yaml Outdated Show resolved Hide resolved
@@ -0,0 +1,26 @@
gromacs:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you want to provide a 2023 recipe? How about just providing the 2024 recipe?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2024 is not supported in Spack 0.21.2. It is only available from 0.22. The problem with using Spack 0.22 is that it has deprecated the --allow-root feature which Stackinator uses internally. So I had to manually copy the recipe from 0.22 and use it on 0.21.2.

But with the required changes in the next release of Stackinator, I can use 0.22 and then we can nuke the 2023 recipe. However, for PLUMED, we will need older versions of GROMACS (2022.5 as of now, but 2023 support is hopefully coming soon).

For interfacing reasons, we will unfortunately have to support the previous year versions of GROMACS as well.

recipes/gromacs/2024/gh200-mpi/config.yaml Outdated Show resolved Hide resolved
recipes/gromacs/2024/gh200-mpi/modules.yaml Outdated Show resolved Hide resolved
@kanduri
Copy link
Collaborator Author

kanduri commented May 22, 2024

cscs-ci run alps;system=santis;uarch=gh200;uenv=gromacs:2023
cscs-ci run alps;system=santis;uarch=gh200;uenv=gromacs:2024

@bcumming
Copy link
Member

cscs-ci run alps;system=todi;uarch=gh200;uenv=gromacs:2023
cscs-ci run alps;system=todi;uarch=gh200;uenv=gromacs:2024

@bcumming
Copy link
Member

cscs-ci run alps;system=todi;uarch=gh200;uenv=gromacs:2024

Comment on lines +14 to +15
- gromacs@2024.1 +cuda +mpi +hwloc
- gromacs@2022.5 +plumed +cuda +hwloc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments on this:

  1. Would it be better having two different environments and use unify: true?
  2. While this has been made clear in the documentation, it might be confusing to have a 2022.5 version in the same uenv. Would it be better to have a different uenv providing 2022.5 (with plumed)? Or is this mix of versions part of a well defined workflow users are used to?

@RMeli RMeli changed the title GROMACS santis GROMACS [GH200] May 31, 2024
@bcumming bcumming merged commit 233bc58 into main Jun 1, 2024
@bcumming bcumming deleted the gromacs-santis branch June 1, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants