Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preparation for v0.5.0 release #1137

Merged
merged 8 commits into from
May 31, 2024
Merged

Preparation for v0.5.0 release #1137

merged 8 commits into from
May 31, 2024

Conversation

rasolca
Copy link
Collaborator

@rasolca rasolca commented May 13, 2024

Draft for v0.5.0 release.

@rasolca rasolca added this to the v0.5.0 milestone May 13, 2024
rasolca
rasolca commented May 13, 2024
View reviewed changes
CITATION.cff Outdated Show resolved Hide resolved
albestro
albestro reviewed May 13, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
albestro
albestro reviewed May 14, 2024
View reviewed changes
BUILD.md Outdated Show resolved Hide resolved
msimberg
msimberg reviewed May 14, 2024
View reviewed changes
BUILD.md Outdated Show resolved Hide resolved
msimberg
msimberg reviewed May 14, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
msimberg
msimberg approved these changes May 14, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@rasolca
Copy link
Collaborator Author

rasolca commented May 14, 2024

Regarding other PRs we might want to include:

  • MPI polling
  • Include file cleanup
  • miniapp as tests
  • pika 0.25.0

Anything you would exclude?
Anything else you want to include?

@msimberg
Copy link
Collaborator

  • MPI polling
    • I think this needs more testing (and importantly still needs a lot of cleanup, possibly also on the pika side)
  • Include file cleanup
    • This could be nice to include
  • miniapp as tests
    • I think if I get to it soon we can include it, but I wouldn't block the release for this
  • pika 0.25.0
    • This is CI-only and doesn't make a difference if it's in before or after the release

I think what's there is already enough for a release. I guess #1016 would be included, but we leave it out of the release notes because it's for internal use?

@RMeli
Copy link
Member

RMeli commented May 14, 2024

I guess #1016 would be included, but we leave it out of the release notes because it's for internal use?

+1 from me for adding #1016 (but not including it in the release notes).

@rasolca
Copy link
Collaborator Author

rasolca commented May 14, 2024

I guess #1016 would be included, but we leave it out of the release notes because it's for internal use?

+1 from me for adding #1016 (but not including it in the release notes).

It is included as master will be released, but not relevant for the user, therefore excluded from the release notes.

@rasolca
Copy link
Collaborator Author

rasolca commented May 14, 2024

pika 0.25.0

* This is CI-only and doesn't make a difference if it's in before or after the release

No differences, but we can say that v0.5.0 is tested with pika@0.25.0...

rasolca and others added 5 commits May 31, 2024 09:37
@rasolca
preparation for v0.5.0 release
7947f8d
@rasolca @msimberg
Update CHANGELOG.md
86c28dd 
Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
@rasolca @albestro
Update CHANGELOG.md
fa65547 
Co-authored-by: Alberto Invernizzi <9337627+albestro@users.noreply.github.com>
@rasolca @msimberg
Update CHANGELOG.md
e2e6209 
Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
@rasolca
Update with new changes
bffa653
@rasolca
Copy link
Collaborator Author

rasolca commented May 31, 2024

Ready to release after merging #1149

@rasolca rasolca marked this pull request as ready for review May 31, 2024 07:51
@rasolca rasolca requested review from albestro and RMeli May 31, 2024 07:51
@rasolca rasolca requested a review from msimberg May 31, 2024 07:51
msimberg
msimberg requested changes May 31, 2024
View reviewed changes
Copy link
Collaborator

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, only two minor requests for changes.

CHANGELOG.md Outdated Show resolved Hide resolved
DOCUMENTATION.md Outdated Show resolved Hide resolved
RMeli
RMeli approved these changes May 31, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
rasolca and others added 2 commits May 31, 2024 10:14
@rasolca @RMeli
Update CHANGELOG.md
65e8106 
Co-authored-by: Rocco Meli <rocco.meli@cscs.ch>
@rasolca @msimberg
Apply suggestions from code review
6f85556 
Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
@rasolca rasolca requested a review from msimberg May 31, 2024 08:18
@rasolca rasolca merged commit 88f2543 into master May 31, 2024
4 checks passed
@rasolca rasolca deleted the pre-v0.5.0 branch May 31, 2024 12:18
github-actions bot pushed a commit that referenced this pull request May 31, 2024
@rasolca
Doc: Preparation for v0.5.0 release (#1137)
a8ef0cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msimberg msimberg msimberg approved these changes

@RMeli RMeli RMeli approved these changes

@aurianer aurianer Awaiting requested review from aurianer

@albestro albestro Awaiting requested review from albestro

Assignees
No one assigned
Labels
Type:Release
Projects
DLA-F Planning
Status: Done
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rasolca @msimberg @RMeli @albestro