Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Black implementation test #2112

Closed
wants to merge 2 commits into from

Conversation

coder2020official
Copy link
Collaborator

@Badiboy this is how approximately black looks like

@coder2020official coder2020official marked this pull request as ready for review January 5, 2024 17:58
@Badiboy
Copy link
Collaborator

Badiboy commented Jan 5, 2024

I PERSONALLY don't like this type of formatting.

image

It gives nothing valuable but lot of lines. It's just one file: you got 1400 lines for nothing. It's valuable for ones who are paid for lines of code :)

@coder2020official
Copy link
Collaborator Author

Idk, since you like changing formatting frequently, I thought you would like an automated system for that

@coder2020official
Copy link
Collaborator Author

I will see whether I can change something in settings though to avoid some of the changes

@Badiboy
Copy link
Collaborator

Badiboy commented Jan 5, 2024

Idk, since you like changing formatting frequently

I don't like ))) I just make some updates to formatting while making valuable updates ))

@coder2020official
Copy link
Collaborator Author

I just tried yapf with a style of facebook, here are some screenshots if you are interested:
image
image
image

This one is still similar to black in some ways, but there are differences. Thoughts? We still have to try to obey PEP-8?

@coder2020official
Copy link
Collaborator Author

We can technically ignore apihelper-like files(also asyncio_helper); Maybe in the future I will even try to get rid of these files due to a mess over there

@Badiboy
Copy link
Collaborator

Badiboy commented Jan 5, 2024

May be just live things as is? 😂😂😂

@coder2020official
Copy link
Collaborator Author

Well, this is not my first time caring about PEP-8 - it is better if we at least try to follow it to some extent.

@Badiboy
Copy link
Collaborator

Badiboy commented Jan 5, 2024

I'm not in favour of carry about anything "because of" - if that does not bring any value. I do not see what value black formatting brings except "now we hava black formatting"...

@coder2020official
Copy link
Collaborator Author

It indeed brings the value of cleaner code

@Badiboy
Copy link
Collaborator

Badiboy commented Jan 5, 2024

"Cleaner code" is not a value. It's "cleaner code bacause of cleaner code".

@coder2020official
Copy link
Collaborator Author

Ok, if it does not harm project in any way - why not accept the new formatting?

@Badiboy
Copy link
Collaborator

Badiboy commented Jan 5, 2024

"Add value" is the good reason of bring changes.
"Why not" is the bad reason of bring changes.

I said it many times before. I say it now. I will say it in future.

@coder2020official
Copy link
Collaborator Author

Well then I can argue that by improving formatting, we follow suggested PEP-8

@coder2020official
Copy link
Collaborator Author

And this is a better practise. The reason is "adding a value", not "why not"

@Badiboy
Copy link
Collaborator

Badiboy commented Jan 5, 2024

"we follow suggested PEP-8" and it will give the project.... What? "Clear code"?

@Badiboy
Copy link
Collaborator

Badiboy commented Jan 5, 2024

"this is a better practise" - do you follow all "better practices" in your life because they are better practices?

@coder2020official
Copy link
Collaborator Author

You should try to follow best practices as far as you can. They are created not for just existence but to help you understand your code faster

@Cub11k
Copy link
Contributor

Cub11k commented Apr 25, 2024

I PERSONALLY don't like this type of formatting.

image

It gives nothing valuable but lot of lines. It's just one file: you got 1400 lines for nothing. It's valuable for ones who are paid for lines of code :)

Consistency in the code formatting for better readability is kinda worth it, provided no one really cares about the number of lines and the size of the py-files (at least in my opinion)

@Badiboy Badiboy closed this Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants