Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add instructions for 3.5->3.4 downgrade. #847

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Add instructions for 3.5->3.4 downgrade. #847

merged 1 commit into from
Jun 4, 2024
+295 −0

Conversation

siyuanfoundation
Copy link
Contributor

@siyuanfoundation
Copy link
Contributor Author

siyuanfoundation commented May 13, 2024 •
edited

/cc @serathius @ahrtr

jmhbnz
jmhbnz reviewed May 15, 2024
View reviewed changes
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this up @siyuanfoundation, some feedback below, pretty minor.

content/en/docs/v3.5/downgrades/downgrade_3_5.md Outdated Show resolved Hide resolved
content/en/docs/v3.5/downgrades/downgrade_3_5.md Outdated Show resolved Hide resolved
content/en/docs/v3.5/downgrades/downgrade_3_5.md Show resolved Hide resolved
@siyuanfoundation siyuanfoundation force-pushed the downgrade branch 2 times, most recently from 078d561 to e034fce Compare May 15, 2024 18:47
@siyuanfoundation
Copy link
Contributor Author

/cc @nate-double-u

@siyuanfoundation
Add instructions for 3.5->3.4 downgrade.
8e96ed6 
Signed-off-by: Siyuan Zhang <sizhang@google.com>
jmhbnz
jmhbnz approved these changes May 18, 2024
View reviewed changes
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @siyuanfoundation

@jmhbnz jmhbnz merged commit 9bc3e6b into etcd-io:main Jun 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmhbnz jmhbnz jmhbnz approved these changes

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

@serathius serathius Awaiting requested review from serathius

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@siyuanfoundation @nate-double-u @serathius @jmhbnz