Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump opentelemetry to v1.4.1 #13723

Closed
wants to merge 1 commit into from
Closed

Conversation

saschagrunert
Copy link

Updating the open telemetry dependencies to their latest release to be
able to fix CVE-2022-23628 (from github.com/open-policy-agent/opa) in
dependent projects.

@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2022

Codecov Report

Merging #13723 (acfd231) into main (6105a6f) will decrease coverage by 0.18%.
The diff coverage is 77.74%.

❗ Current head acfd231 differs from pull request most recent head 49ab663. Consider uploading reports for the commit 49ab663 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13723      +/-   ##
==========================================
- Coverage   72.77%   72.58%   -0.19%     
==========================================
  Files         465      466       +1     
  Lines       37842    38201     +359     
==========================================
+ Hits        27538    27728     +190     
- Misses       8525     8670     +145     
- Partials     1779     1803      +24     
Flag Coverage Δ
all 72.58% <77.74%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/config/config.go 79.51% <ø> (ø)
server/etcdmain/etcd.go 45.16% <0.00%> (-0.60%) ⬇️
server/etcdserver/bootstrap.go 68.79% <25.00%> (+0.67%) ⬆️
server/etcdserver/apply.go 90.16% <27.27%> (-0.99%) ⬇️
server/embed/config.go 72.41% <68.42%> (-0.78%) ⬇️
server/etcdserver/api/v3discovery/discovery.go 80.00% <80.00%> (ø)
server/embed/etcd.go 75.39% <100.00%> (+1.20%) ⬆️
server/etcdmain/config.go 84.94% <100.00%> (+0.67%) ⬆️
server/etcdserver/server.go 84.60% <100.00%> (-0.20%) ⬇️
client/v3/snapshot/v3_snapshot.go 0.00% <0.00%> (-52.09%) ⬇️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6105a6f...49ab663. Read the comment docs.

@ptabor
Copy link
Contributor

ptabor commented Feb 21, 2022

Please also execute:

./scripts/updatebom.sh

Updating the open telemetry dependencies to their latest release to be
able to fix CVE-2022-23628 (from github.com/open-policy-agent/opa) in
dependent projects.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert
Copy link
Author

Please also execute:

./scripts/updatebom.sh

Done, thank you for the hint!

@ptabor
Copy link
Contributor

ptabor commented Feb 22, 2022

The tests seems to be more failing/timingout/leaking goroutines that in other base-line PRs.

I expect there is some correlation between changes caused by the version bump and failures of tests, especially,
those run by:

(cd tests && 'env' 'go' 'test' '-v' '-json' '-timeout=15m' '--race=false' '--cpu=1' './integration/...')

@saschagrunert
Copy link
Author

saschagrunert commented Feb 23, 2022

Ugh, I have to revisit this PR to fix the CI.

@saschagrunert
Copy link
Author

This may be related to googleapis/google-cloud-go#5430 and grpc/grpc-go#5171

@ahrtr
Copy link
Member

ahrtr commented May 15, 2022

There are some behavior changes in grpc 1.42 and 1.43, it might be needing some code change.
FYI. https://github.com/grpc/grpc-go/releases

Please rebase this PR, and try to resolve the test failures if you are still interested in merging this PR.

@saschagrunert saschagrunert deleted the otel branch May 16, 2022 07:40
@saschagrunert
Copy link
Author

Closing for now since I do not have the priorities to pick it up in the next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants