-
Notifications
You must be signed in to change notification settings - Fork 851
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
"angular || null" will return an error if angular is not defined, not null as expected this change makes ng-table compatible with requireJS (bug appeared when ng-table was loaded before angular, that can happen at random)
- Loading branch information
1 parent
93b4846
commit 81d5795
Showing
1 changed file
with
2 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
81d5795
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change should have happened in the script 01-intro.js and not here - when you run grunt it will concatenate the source file and this change will be overridden.
81d5795
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yairy Exactly, I fixed it in this PR #307