Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(onewire): raise recovery time to support more sensor on longer wire (IEC-111) #329

Merged
merged 1 commit into from
May 28, 2024

Conversation

muggenhor
Copy link
Contributor

Change description

Specifically this is the time that's necessary to be able to perform a device search on a bus consisting of >= 6 devices on >= 10m of wire at 5V with a 4.7 kΩ pull-up resistor.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot changed the title fix(onewire): raise recovery time to support more sensor on longer wire fix(onewire): raise recovery time to support more sensor on longer wire (IEC-111) May 17, 2024
@muggenhor
Copy link
Contributor Author

muggenhor commented May 17, 2024

I'm not signing a contract with a company I don't know (the CLA). I also don't believe this single change in number is copyrightable (not an "original work"). So feel free to regard this PR as a bug report with suggested fix direction instead.

EDIT: Also, at a glance, this CLA seems to be about grants of copyright license and patent. Both are already covered by the Apache 2.0 license which by my act of creating this PR I've implicitly agreed to. So this feels like extra "Cover Your Ass" legalese on top of that. And I'm not willing to hire a lawyer to verify that there's no hidden sneaky stuff in here.

Specifically this is the time that's necessary to be able to perform a
device search on a bus consisting of >= 6 devices on >= 10m of wire at
5V with a 4.7 kΩ pull-up resistor.
Copy link
Collaborator

@suda-morris suda-morris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@suda-morris suda-morris merged commit 3c36d05 into espressif:master May 28, 2024
70 of 71 checks passed
@suda-morris
Copy link
Collaborator

I will bump up the version of onewire component later

@muggenhor muggenhor deleted the fix/onewire-timing branch June 5, 2024 13:28
@muggenhor
Copy link
Contributor Author

Thanks for merging this! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants