-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ccronexpr components for parse CRON expression (IEC-88) #304
Add ccronexpr components for parse CRON expression (IEC-88) #304
Conversation
3ab21c6
to
3233531
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @ESP-YJM, I left a few comments.
Please also add at least a simple example project illustrating how to use this library.
5f59334
to
8165a09
Compare
@igrr Sorry for taking so long to update. If you have time, please help to review it again. |
|
||
## API Reference | ||
|
||
To learn more about how to use this component, please check API Documentation from header file [ccronexpr.h](https://github.com/espressif/idf-extra-components/blob/master/supertinycron/supertinycron/ccronexpr.h) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link gives a 404 error (i think because it points inside a submodule, which github doesn't support.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It points to master branch, maybe after merge the PR and can access it.
@ESP-YJM LGTM aside the few things mentioned. |
f858b9d
to
a04ca02
Compare
a04ca02
to
ff41564
Compare
@ESP-YJM Thanks for the fixes, just one more thing seems to be remaining:
Please use |
ff41564
to
35a448b
Compare
@ESP-YJM Thank you for the contribution! |
Checklist
url
field definedChange description
Please describe your change here