Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coap: Add mbedTLS and debug config for CoAP build option (IEC-19) #100

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ESP-YJM
Copy link
Contributor

@ESP-YJM ESP-YJM commented Oct 26, 2022

Checklist

  • Component contains License
  • Component contains README.md
  • Component contains idf_component.yml file with url field defined
  • Component was added to upload job
  • Component was added to build job
  • Optional: Component contains unit tests
  • CI passing

Change description

  1. Add COAP_MBEDTLS_SUPPORT Kconfig to make CoAP support DTLS or not. This can help save about 80 KB firmware size.
  2. Depend on COAP_MBEDTLS_DEBUG Kconfig to make CoAP support debug or not. This can help save about 20 KB firmware size.

@CLAassistant
Copy link

CLAassistant commented Oct 26, 2022

CLA assistant check
All committers have signed the CLA.

@ESP-YJM ESP-YJM force-pushed the feature/optimize_coap_config branch from 773e67f to f0c4cb2 Compare October 26, 2022 08:24
help
Enable mbedTLS functionality for CoAP.

If this option is disabled, redundent CoAP mbedTLS code is removed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will also make the underlying transport insecure. I am not sure how this config would be really helpful, can you please elaborate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When only need CoAP and no DTLS, we can disable this config and it will save a lot of firmware size. I agree that CoAP transported without DTLS is not secure, but users can encrypt the CoAP payload themselves and then transport it using CoAP, which is also a way to use it. Just as RainMaker uses HTTP for local control instead of HTTPS, the data content is encrypted by negotiation. And I am going to add CoAP transmission to the protocomm layer. At present, I am comparing the memory, time and firmware size of HTTP and CoAP. Later, I will provide MR internally, and I need you to share your suggestions.

@github-actions github-actions bot changed the title coap: Add mbedTLS and debug config for CoAP build option coap: Add mbedTLS and debug config for CoAP build option (IEC-19) May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants