-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added en-ja to MUST_C_V2 dataset (ST) recipes #5648
base: master
Are you sure you want to change the base?
added en-ja to MUST_C_V2 dataset (ST) recipes #5648
Conversation
FYI @brianyan918 |
must_c_v2/asr1 missing data.sh |
|
See https://github.com/espnet/espnet/blob/master/egs2/aishell/asr1/README.md as a reference. |
LGTM thanks @jasonmusespresso |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5648 +/- ##
===========================================
+ Coverage 14.24% 48.96% +34.72%
===========================================
Files 757 494 -263
Lines 69304 43593 -25711
===========================================
+ Hits 9872 21346 +11474
+ Misses 59432 22247 -37185
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
egs2/must_c_v2/st1/conf/slurm.conf
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should not change it with our local setup
It looks good to me, but I want to have input from @brianyan918
|
The sacrebleu_opt_extra looks good, but shouldn't there be some value passed from run.sh? @jasonmusespresso |
@brianyan918 yes, added it. in my run, I pass it when calling ./run.sh (e.g. ./run.sh --stage 13 --stop-stage 17 --sacrebleu_opt_extra "-tok ja-mecab -l en-ja --smooth-method exp"...), which should also work. |
What?
added and tested two new target languages
Why?
language expansion for must_c_v2
Attentional Enc-Dec (st_train_st_conformer_raw_en_ja_bpe_tc4000_sp)
3.9.18 (main, Sep 11 2023, 13:41:44) [GCC 11.2.0]
espnet 202402
pytorch 2.1.0
See also