Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iperf_api: memset entire malloc #1670

Merged
merged 1 commit into from
May 24, 2024
Merged

iperf_api: memset entire malloc #1670

merged 1 commit into from
May 24, 2024

Conversation

RABijl
Copy link
Contributor

@RABijl RABijl commented Mar 19, 2024

PLEASE NOTE the following text from the iperf3 license. Submitting a
pull request to the iperf3 repository constitutes "[making]
Enhancements available...publicly":

You are under no obligation whatsoever to provide any bug fixes, patches, or
upgrades to the features, functionality or performance of the source code
("Enhancements") to anyone; however, if you choose to make your Enhancements
available either publicly, or directly to Lawrence Berkeley National
Laboratory, without imposing a separate written license agreement for such
Enhancements, then you hereby grant the following license: a non-exclusive,
royalty-free perpetual license to install, use, modify, prepare derivative
works, incorporate into other computer software, distribute, and sublicense
such enhancements or derivative works thereof, in binary and source code form.

The complete iperf3 license is available in the LICENSE file in the
top directory of the iperf3 source tree.

  • Version of iperf3 (or development branch, such as master or
    3.1-STABLE) to which this pull request applies:

  • Issues fixed (if any):

  • Brief description of code changes (suitable for use as a commit message):
    in the function iperf_new_test
    the bitrate_limit_intervals_traffic_bytes array
    was only memset for the size of the sizeof
    return type, instead of the entire array.

while we're on this topic, is there are reason why calloc is not used but instead of malloc + memset?

in the function iperf_new_test
the  bitrate_limit_intervals_traffic_bytes array
was only memset for the size of the sizeof
return type, instead of the entire array.
@bmah888 bmah888 added the bug label Mar 22, 2024
@bmah888
Copy link
Contributor

bmah888 commented Mar 22, 2024

Thanks for the PR! Yeah that's a pretty silly bug isn't it.

@bmah888 bmah888 merged commit 7a082f5 into esnet:master May 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants