Chore: Convert non-lib/test files to template literals (refs #6407) #7329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kaicataldo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nzakas, @mysticatea and @btmills to be potential reviewers. |
|
LGTM |
not-an-aardvark
approved these changes
Oct 9, 2016
mysticatea
approved these changes
Oct 9, 2016
| @@ -68,7 +68,7 @@ const NODE = "node ", // intentional extra space | |||
| TEST_FILES = getTestFilePatterns(), | |||
| PERF_ESLINTRC = path.join(PERF_TMP_DIR, "eslintrc.yml"), | |||
| PERF_MULTIFILES_TARGET_DIR = path.join(PERF_TMP_DIR, "eslint"), | |||
| PERF_MULTIFILES_TARGETS = PERF_MULTIFILES_TARGET_DIR + path.sep + "{lib,tests" + path.sep + "lib}" + path.sep + "**" + path.sep + "*.js", | |||
| PERF_MULTIFILES_TARGETS = `${PERF_MULTIFILES_TARGET_DIR + path.sep}{lib,tests${path.sep}lib}${path.sep}**${path.sep}*.js`, | |||
There was a problem hiding this comment.
Wondering if this would be more readable as an array join?
There was a problem hiding this comment.
Yeah, definitely could be - I'm not opposed to that :)
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain:
Chore: using the new
prefer-templateautofix to start converting files so we can enableprefer-templatein the ESLint repo. Originally discussed here.Please check each item to ensure your pull request is ready:
What changes did you make? (Give an overview)
Used the new
prefer-templateautofix (followed up by thetemplate-curly-spacing, which is already enabled in the ESLint repo) on JS files not inside lib/ or tests/.Is there anything you'd like reviewers to focus on?
I manually checked everything, but would love to get eyes on this, especially since Makefile is untested.
I manually changed some now unnecessary escaped double quotes into unescaped double quotes.